CSTACKEX-18: Cloudstack snapshot workflow for NFS3 protocol#26
Open
rajiv-jain-netapp wants to merge 4 commits intomainfrom
Open
CSTACKEX-18: Cloudstack snapshot workflow for NFS3 protocol#26rajiv-jain-netapp wants to merge 4 commits intomainfrom
rajiv-jain-netapp wants to merge 4 commits intomainfrom
Conversation
rajiv-jain-netapp
requested review from
piyush5netapp,
sandeeplocharla and
suryag1201
suryag1201
reviewed
Jan 29, 2026
|
|
||
| VolumeVO volumeVO = volumeDao.findById(volumeInfo.getId()); | ||
| if(volumeVO == null) { | ||
| throw new CloudRuntimeException("takeSnapshot: VolumeVO not found for id: " + volumeInfo.getId()); |
suryag1201
reviewed
Feb 10, 2026
| @@ -227,6 +239,79 @@ public long getUsedIops(StoragePool storagePool) { | |||
| @Override | |||
| public void takeSnapshot(SnapshotInfo snapshot, AsyncCompletionCallback<CreateCmdResult> callback) { | |||
|
|
|||
| CreateCmdResult result; | |||
There was a problem hiding this comment.
Add condition for snapshot "null" condition
suryag1201
reviewed
Feb 10, 2026
| switch (protocolType) { | ||
| case NFS3: | ||
| cloudStackVolumeRequest = new CloudStackVolume(); | ||
| FileInfo fileInfo = new FileInfo(); |
suryag1201
reviewed
Feb 10, 2026
|
|
||
| CloudStackVolume cloudStackVolumeRequest = getCloudStackVolumeRequestByProtocol(poolDetails, volumeVO.getPath()); | ||
| CloudStackVolume cloudStackVolume = storageStrategy.getCloudStackVolume(cloudStackVolumeRequest); | ||
| if (cloudStackVolume == null || cloudStackVolume.getFile() == null) { |
There was a problem hiding this comment.
this is a common code for Lun and File so this condition will fail for ISCSI
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?